Skip to content

fix: support ClusterCacheTracker #5556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

fix: support ClusterCacheTracker #5556

merged 1 commit into from
Apr 18, 2025

Conversation

@mweibel
Copy link
Contributor

@mweibel mweibel commented Apr 8, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
ClusterCacheTracker is only enabled if POD_NAME, POD_NAMESPACE, and POD_UID are set.

https://github.com/kubernetes-sigs/cluster-api/blob/5815de795489c3edfca22a2c35cd87d7143d9545/controllers/clustercache/cluster_cache.go#L283-L296

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

fixes manager deployment to enable cluster cache tracker

@mweibel
fix: support ClusterCacheTracker
cc6390d 
POD_UID is required for clusterCacheTracker to work
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mweibel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.86%. Comparing base (df608bd) to head (cc6390d).
Report is 25 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5556   +/-   ##
=======================================
  Coverage   52.86%   52.86%           
=======================================
  Files         272      272           
  Lines       29474    29474           
=======================================
  Hits        15582    15582           
  Misses      13080    13080           
  Partials      812      812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nawazkh
Copy link
Member

nawazkh commented Apr 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7cfe2c109384f078b2f4646a12e5eb456de13b29

@mboersma
Copy link
Contributor

mboersma commented Apr 8, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2025
@mweibel
Copy link
Contributor Author

mweibel commented Apr 9, 2025

/retest

mboersma
mboersma approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2025
@nawazkh
Copy link
Member

nawazkh commented Apr 17, 2025

/retest

@nawazkh
Copy link
Member

nawazkh commented Apr 17, 2025

/cherry-pick release-1.18

@k8s-infra-cherrypick-robot
Copy link

@nawazkh: once the present PR merges, I will cherry-pick it on top of release-1.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nawazkh
Copy link
Member

nawazkh commented Apr 17, 2025

/cherry-pick release-1.19

@k8s-infra-cherrypick-robot
Copy link

@nawazkh: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mboersma
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0c26c46 into kubernetes-sigs:main Apr 18, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Apr 18, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Apr 18, 2025
@k8s-infra-cherrypick-robot
Copy link

@nawazkh: new pull request created: #5572

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@nawazkh: new pull request created: #5573

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@mboersma mboersma

@nawazkh nawazkh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

CAPZ Planning
Status: Done

Milestone

v1.20

Development

Successfully merging this pull request may close these issues.

5 participants

@mweibel @k8s-ci-robot @nawazkh @mboersma @k8s-infra-cherrypick-robot